Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58 standardise parent class #67

Merged
merged 12 commits into from
Jul 12, 2023
Merged

Conversation

retinfai
Copy link
Collaborator

Standardise the parent class:
All environments (including CarGoal) extend the F1tenthEnvironment (prev CarGeneralEnvironment)
The responsibility of the F1tenthEnvironment is to handle all the subscriptions/publishers, which includes the publishing of the velocity commands as well as the fetching of the raw data.

From there, the child defines the environment specific information – eg. move OBSERVATION_SIZE to child class. In addition defines the get_observation, is_terminated.

Extracted functions that shouldn't be in a class into the util.py and termination.py.

Also, merged the CarTrack Environment classes :

Renamed the tracks:

  • track_1.sdf
  • track_2.sdf
  • track_3.sdf

ClientSide:

  • Pass the track name into as parameter CarTrackEnvironment(..., track='track_1')

ResetSide:

  • Update the cartrack.launch.py to take the track name as launch argument passed when including it in the train.launch.py.
  • Also added config support – can define the track inside the train.yaml file.

@retinfai retinfai linked an issue Jul 11, 2023 that may be closed by this pull request
This was linked to issues Jul 11, 2023
Copy link
Contributor

@Bac0nEater Bac0nEater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning my mess

@emilysteiner71 emilysteiner71 merged commit d116d55 into master Jul 12, 2023
@Jack17432 Jack17432 deleted the 58-standardise-parent-class branch July 13, 2023 01:45
Doge-God pushed a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge CarTrack Environments Standardise Parent class Extract helper functions to util
3 participants