Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to delete single legal values #9058

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jan 3, 2025

About the changes

Deleting single legal value in a context field

Details:

  • refactored methods to be less verbose
  • permission is the same as for adding/updating legal values
  • returning 200 for the sake of consistency with other methods in the controller

Important files

Discussion points

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 2:27pm

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

src/lib/features/context/context.ts Outdated Show resolved Hide resolved
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
@kwasniew kwasniew merged commit c56200e into main Jan 3, 2025
10 of 11 checks passed
@kwasniew kwasniew deleted the delete-single-legal-value branch January 3, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants