chore: Added tests for edge and client_api #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added some Tarpaulin exclusion arguments to better reflect code coverage across code that we actually want to cover. There's still some work to do with regards to having the possibility to instantiate the entire application as a test service for full integration/e2e tests, but this at least covers more logic and also exposed a bug in how we validated keys when not using a token validator (offline mode))
sighphyre
reviewed
Mar 8, 2023
| .map(|features| features.clone()) | ||
| .map(|client_features| ClientFeatures { |
There was a problem hiding this comment.
YESSS. Let's also make sure this goes into the commit message as a fix
sighphyre
reviewed
Mar 8, 2023
| ClientFeatures { | ||
| version: 2, | ||
| features: vec![ | ||
| ClientFeature { |
There was a problem hiding this comment.
I think we have a Default impl on ClientFeature. Entirely optional but it might make this huge blob easier to read
sighphyre
reviewed
Mar 8, 2023
server/tarpaulin.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [all] | |||
| exclude-files= ["src/main.rs", "" | |||
sighphyre
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some Tarpaulin exclusion arguments to better reflect code coverage across code that we actually want to cover.
There's still some work to do with regards to having the possibility to instantiate the entire application as a test service for full integration/e2e tests, but this at least covers more logic and also exposed a bug in how we validated keys when not using a token validator (offline mode))