Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an issue where client features wouldn't correctly update #64

Merged
merged 2 commits into from
Feb 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion server/src/data_sources/memory_provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl MemoryProvider {
self.data_store
.entry(key(token))
.and_modify(|data| {
data.clone().merge(features.clone());
*data = data.clone().merge(features.clone());
})
.or_insert(features);
}
Expand Down Expand Up @@ -335,6 +335,53 @@ mod tests {
assert!(found_feature.name == *"James Bond");
}

#[tokio::test]
async fn memory_provider_can_update_data() {
let mut provider = MemoryProvider::default();
let token = EdgeToken {
environment: Some("development".into()),
projects: vec!["default".into()],
token: "some-secret".into(),
..EdgeToken::default()
};

let first_features = ClientFeatures {
version: 1,
features: vec![ClientFeature {
name: "James Bond".into(),
project: Some("default".into()),
..ClientFeature::default()
}],
segments: None,
query: None,
};
let second_features = ClientFeatures {
version: 1,
features: vec![ClientFeature {
name: "Jason Bourne".into(),
project: Some("default".into()),
..ClientFeature::default()
}],
segments: None,
query: None,
};

provider.sink_features(
&token,
second_features.clone(),
into_entity_tag(second_features),
);
provider.sink_features(
&token,
first_features.clone(),
into_entity_tag(first_features),
);

let all_features = provider.get_client_features(&token).await.unwrap().features;

assert!(all_features.len() == 2);
}

#[tokio::test]
async fn memory_provider_respects_all_projects_in_token() {
let mut provider = MemoryProvider::default();
Expand Down