task: client metrics start task #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Hornby <sighphyre@users.noreply.github.com> Co-authored-by: Gastón Fournier <gaston@getunleash.ai>
chriswk
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
This looks good to me. Nice work Nuno. @sighphyre have a look as well would you?
sighphyre
reviewed
Feb 9, 2023
| @@ -30,6 +30,15 @@ impl TokenSource for OfflineProvider { | |||
| Ok(self.valid_tokens.values().cloned().collect()) | |||
| } | |||
|
|
|||
| async fn get_valid_tokens(&self) -> EdgeResult<Vec<EdgeToken>> { | |||
There was a problem hiding this comment.
Idle thoughts but it looks like we might end up writing this same method over and over. Might be worth implementing this as a trait on Vec<EdgeToken>. Not something for this PR
sighphyre
reviewed
Feb 9, 2023
| } | ||
| } | ||
|
|
||
| tokio::time::sleep(Duration::from_secs(send_interval)).await; | ||
| } | ||
| } | ||
|
|
||
| async fn get_first_token(source: Arc<RwLock<dyn EdgeSource>>) -> EdgeResult<EdgeToken> { |
There was a problem hiding this comment.
Also idle thoughts, but if this feels like it wants to be an option not a result. Doesn't need to be done in this PR
sighphyre
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
send_metrics_taskto our running tasks. It accepts a new arg:metrics_interval_seconds.Rename
get_valid_tokenstofilter_valid_tokensto better reflect its behaviour. Addget_valid_tokensto return all valid tokens from our store.Implement
background_send_metrics.