task: Updated to only refresh tokens of type Client #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c449d9 to
41b7158
Compare
nunogois
reviewed
Feb 6, 2023
| if let Err(err) = sink_result { | ||
| warn!("Couldn't sink token result: {err:?}") | ||
| } else { | ||
| let _ = feature_channel.send(token).await; | ||
| for valid in validated_tokens { | ||
| let _ = feature_channel.send(valid).await; |
There was a problem hiding this comment.
Would it be better to only send in filtered "client" tokens to the channel instead of sending in everything and filtering on the refresh_features method?
There was a problem hiding this comment.
Occurred to me as well. I suspect we're going to tap into this from more than just this place, though, so it's nice to be defensive. Probably something for a future PR when the structure is more settled here if we only call this from the one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having thought about this over the weekend this PR includes two optimizations. One for sending on the validated_tokens from the validate token channel. One for filtering which tokens the feature_refresh_channel keeps on TokenType. Should prevent us from receiving 403's from Upstream.
Also pointed out to me that our auth middleware also needs to check the tokentype before allowing/disallowing the call.