Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use Version-headers to decide where to post metrics #389

Merged
merged 4 commits into from
Jan 15, 2024
Merged

feat: Use Version-headers to decide where to post metrics #389

merged 4 commits into from
Jan 15, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jan 12, 2024

Will now post to /api/client/metrics/bulk if upstream returns

  • Edge version 17.0.0 or newer.
  • Unleash version 5.9.0 or newer (or actually 5.8.0+main, our tip of main).

@chriswk chriswk requested a review from sighphyre January 12, 2024 14:57
@chriswk chriswk self-assigned this Jan 12, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 12, 2024
View reviewed changes
server/src/http/unleash_client.rs Fixed Show resolved Hide resolved
server/src/metrics/client_metrics.rs Fixed Show fixed Hide fixed
sighphyre
sighphyre approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Clippy warning should be an easy fix

@chriswk chriswk merged commit 4f9c7ee into main Jan 15, 2024
9 checks passed
@chriswk chriswk deleted the useHeadersToDecideWhereToPostMetrics branch January 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees

@chriswk chriswk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriswk @sighphyre