Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd http metrics #351

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: readd http metrics #351

merged 1 commit into from
Nov 27, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Nov 27, 2023

After upgrading opentelemetry we lost our http metrics on our prometheus metrics dump due to a different call setup for getting it to work. This PR again sets up our configured meter provider to be used for all prometheus metrics. Which allows us to have our custom middleware work again.

After upgrading opentelemetry we lost our http metrics on our prometheus
metrics dump due to a different call setup for getting it to work. This
PR again sets up our configured meter provider to be used for all
prometheus metrics. Which allows us to have our custom middleware work
again.
@chriswk chriswk requested a review from sighphyre November 27, 2023 13:33
@chriswk chriswk self-assigned this Nov 27, 2023
@chriswk chriswk enabled auto-merge (squash) November 27, 2023 14:17
Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriswk chriswk merged commit 034a4b2 into main Nov 27, 2023
6 checks passed
@chriswk chriswk deleted the fix/reAddHttpMetrics branch November 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants