Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make edge log bad request information from upstream #313

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Oct 24, 2023

We have one customer that is reporting that their Edge installation is getting 400 from upstream when reporting batch metrics. This PR extends the data we keep when Edge receives a 400 from upstream batch endpoint and tries to parse the message that comes back from ajv.

It should make it easier to debug why Edge is unable to format metrics correctly.

@chriswk chriswk requested review from sjaanus and sighphyre October 24, 2023 14:09
@chriswk chriswk self-assigned this Oct 24, 2023
@chriswk chriswk force-pushed the feat/log400MessagesFromUnleash branch from a800cf3 to d3cdd44 Compare October 24, 2023 14:09
@chriswk chriswk force-pushed the feat/log400MessagesFromUnleash branch from d3cdd44 to b45c5c1 Compare October 24, 2023 14:10
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriswk chriswk merged commit e77ea18 into main Oct 25, 2023
4 checks passed
@chriswk chriswk deleted the feat/log400MessagesFromUnleash branch October 25, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants