Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: slight refactor and mock token validation #31

Merged
merged 2 commits into from
Feb 2, 2023
Merged

test: slight refactor and mock token validation #31

merged 2 commits into from
Feb 2, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Feb 1, 2023

Slight refactoring and mocks token validation on the test server.

@nunogois nunogois requested a review from chriswk February 1, 2023 20:39
chriswk
chriswk approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Nuno. Love the simplification based on what we found on required headers.

sighphyre
sighphyre approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nunogois nunogois merged commit 55a577c into task/validate_token_request Feb 2, 2023
@nunogois nunogois deleted the task/validate_token_request_mock_token_validation branch February 2, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

@chriswk chriswk chriswk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunogois @chriswk @sighphyre