fix: allow multiple client tokens at startup #188
Conversation
| @@ -145,12 +145,8 @@ impl FeatureRefresher { | |||
| } | |||
|
|
|||
| /// | |||
| /// Registers a token for refresh, returns true if token did not exist and as such needs hydration before we can guarantee that we have data for it | |||
There was a problem hiding this comment.
Patches to this function are just for sanity. The doc string got outdated here and we never updated it. This function could also never fail - there was no path to raise an error but the function signature suggested that it could, so now the return signature reflects that . You'll see a few places in this PR where
let _ = feature_refresher has been swapped for feature_refresher, which is married to the change to this function
| .collect() | ||
| } | ||
|
|
||
| fn filter_unique_tokens(tokens: &[TokenRefresh]) -> Vec<TokenRefresh> { |
There was a problem hiding this comment.
The TokenRefresh type already has a Hash impl, so we gotta go the long way around to make a unique list here
Me too - that's why we write tests haha |
Fixes an issue where providing multiple tokens on startup with identical environments and projects would result in no tokens being registered.
This was caused by overeager subsumption of the tokens - identical tokens would subsume each other, and therefore the result of two identical tokens would be no tokens. I've patched this by creating a new list of only tokens that do not have a match for identical project/environment before we do the subsumption.