chore: allow output from bad requests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, we have no way of knowing why an API request has failed outside of logging. This means that if we miss a log somewhere we have to patch the code in order to understand why it does what it does. This is worse for users because they can't do that and at very best it means fiddling with logging levels to try to figure out what's going on.
What
This patches the response to include the scrubbed error message as yielded by the
impl Display for EdgeErrorimplementation. Incoming SDKs will not understand the response here but they will discard the output anyway. Humans, on the other hand, can now understand why a request failed and hopefully how to address it