fix: Use split_once. #164
Merged
fix: Use split_once. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had forgotten that `:` is a valid part of a header value, so splitting on `'` ended up splitting into too many parts and thus failing the parser. This PR changes to use split_once, which splits on first occurrence. Since Header Names are not allowed to contains `:` this will be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had forgotten that
:is a valid part of a header value, so splitting on:ended up splitting into too many parts and thus failing the parser. This PR changes to use split_once, which splits on first occurrence. Since Header Names are not allowed to contain:this will be fine