Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes incorrect parsing of extra arguments. #156

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Apr 14, 2023

Currently we do not parse extra parameters into the properties holder for the context. This PR updates edge to make sure that overflows (properties we haven't explicitly defined) get parsed into the properties map

Currently we do not parse extra parameters into the properties holder
for the context. This PR updates to make sure that overflows (properties
we haven't explicitly defined) get parsed into the properties map
@chriswk chriswk requested a review from sighphyre April 14, 2023 13:05
@chriswk chriswk self-assigned this Apr 14, 2023
@chriswk chriswk added the bug Something isn't working label Apr 14, 2023
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk merged commit a4930e6 into main Apr 14, 2023
@chriswk chriswk deleted the fix/handleMissingContextFields branch April 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants