Fix double slash in url. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daveleek could you please take a look? |
thomasheartman
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Hey, @mstyura! This seems like a very good change to me and I'm all for it! 🔥
Gonna double check internally, but I imagine we can just go ahead and merge it.
Thanks for the PR and good work on this 🙌🏼
|
Noticed Clippy is failing for a file you haven't touched. That should be perfectly safe to ignore, but I wanna see if I can make CI green before merging anything. I've linked the (merged) pull request that fixes it. Would you mind just rebasing / merging those changes so we can get the full pipeline to green? |
45c848b to
4632fde
Compare
4632fde to
8b9935f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
It was unclear whether it was expected by user that provided API url is end with
/or not. I've actually passed URL with trailing/, which ended up inability to register client. It wen't unnoticed until deployed on prod, because there was different URL.I've made a change to make SDK tolerate URLs ended with
/by trimming user-provided URL before concatenation with rest of endpoint.Important files
Discussion points