Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions to use upstream binary packages #419

Merged

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jun 23, 2022

The build instructions are rather outdated, as we don't need to build any upstream packages from source anymore.

The old instructions have probably lead to issues like #413

@fmauch fmauch added the Foxy label Jun 23, 2022
@fmauch fmauch requested a review from RobertWilbrandt June 23, 2022 07:11
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (foxy@55cb097). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             foxy    #419   +/-   ##
======================================
  Coverage        ?   3.73%           
======================================
  Files           ?      16           
  Lines           ?    1071           
  Branches        ?     212           
======================================
  Hits            ?      40           
  Misses          ?     942           
  Partials        ?      89           
Flag Coverage Δ
unittests 3.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55cb097...b88f329. Read the comment docs.

Copy link
Contributor

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable for foxy

@RobertWilbrandt RobertWilbrandt merged commit 69c2030 into UniversalRobots:foxy Jun 28, 2022
@fmauch fmauch deleted the foxy_update_build_instructions branch June 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants