Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[to consider] dirty reentrancy lock #189

Merged
merged 4 commits into from
Nov 28, 2022
Merged

[to consider] dirty reentrancy lock #189

merged 4 commits into from
Nov 28, 2022

Conversation

hensha256
Copy link
Collaborator

Gas is better for our contracts with a dirty lock not a clean one - you can see this in the 2 commits

snreynolds
snreynolds approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just maybe worth adding a test with a malicious nft contract that tries to re-enter?

@hensha256 hensha256 merged commit d82c668 into main Nov 28, 2022
@hensha256 hensha256 deleted the reentrancy-lock-clean branch November 28, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snreynolds snreynolds snreynolds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hensha256 @snreynolds