Broken S3 implementation for netcdf files on non-AWS + Authenticated buckets #3098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumble upon this when trying to read a netcdf file from a non-AWS S3 bucket that requires authorization.
I used minio public testing S3 server (~/.aws/credentials)
It seems that this is working for publicly available netcdf files in AWS S3 like the ones on the used on the
nczarr_test/run_external.sh
I fixed this with 7a11d8c
But I also noticed that one must always have a profile defined in order to make it work, so c791ddb will load try to load
AWS_ACCESS_KEY_ID
,AWS_SECRET_ACCESS_KEY
, andAWS_REGION
from the environment if the profile is not set & there is no default profile (which is a valid case).I'd like to add this as a test but I really think relying on the play.min.io is not the way to go. Perhaps a github actions workflow where minio-server gets deployed and serves the S3 tests.