Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pom.xml definitions for compliance with OSSRH #2 #3

Merged
merged 4 commits into from
Apr 23, 2015

Conversation

lewismc
Copy link
Contributor

@lewismc lewismc commented Apr 21, 2015

Hi Folks (specifically @JohnLCaron ),
This is a pull request which will allow us to distribute this artifact via Maven Central as per the workflows which we have been working to. The proposed changes fit in with the existing workflow but you will now see that javadoc.jar and sources.jar artifacts accompany the usual .jar
Thanks
Lewis

@dopplershift
Copy link
Member

Thanks for the contribution. Can you correct the license you specify in the pom.xml? You made it Apache, but in reality the original jj2000 developers used their own license, which is specified in the COPYRIGHT file in the base of the repo.

@lewismc
Copy link
Contributor Author

lewismc commented Apr 22, 2015

Hi Ryan... Doh, yes will do so. Sending PR ASAP thanks for review.

On Wednesday, April 22, 2015, Ryan May notifications@github.com wrote:

Thanks for the contribution. Can you correct the license you specify in
the pom.xml? You made it Apache, but in reality the original jj2000
developers used their own license, which is specified in the COPYRIGHT file
in the base of the repo.


Reply to this email directly or view it on GitHub
#3 (comment).

Lewis

@lewismc
Copy link
Contributor Author

lewismc commented Apr 23, 2015

hi @dopplershift I've removed the license but retainer the license markup. The reasoning is that there is a COPYRIGHT, but no License I can see. If you see differently then please inform and I will update again.

@dopplershift
Copy link
Member

When I read the COPYRIGHT file, it sounds like a license:

  • Original authors assume no liability
  • Can only use this code for jpeg2k implementations
  • The original copyright notice needs to be distributed with code and derivative works.

@lewismc
Copy link
Contributor Author

lewismc commented Apr 23, 2015

Hi Ryan, if you have a suggestion about which license then I would be only
too happy to add it.
I'll update the PR for he versioning in 5 mins. Sorry about that, it was so
I could publish the artifact to central.

On Thursday, April 23, 2015, Ryan May notifications@github.com wrote:

When I read the COPYRIGHT file, it sounds like a license:

  • Original authors assume no liability
  • Can only use this code for jpeg2k implementations
  • The original copyright notice needs to be distributed with code and
    derivative works.


Reply to this email directly or view it on GitHub
#3 (comment).

Lewis

@dopplershift
Copy link
Member

Personally, I'd just call it the jj2000 license. If it needs to be a known license, then I'd leave it blank.

I can take care of that later if you don't want to bother.

@lewismc
Copy link
Contributor Author

lewismc commented Apr 23, 2015

@dopplershift done :)
Thank you

dopplershift added a commit that referenced this pull request Apr 23, 2015
 Implement pom.xml definitions for compliance with OSSRH

Fixes #2.
@dopplershift dopplershift merged commit 27de0c5 into Unidata:master Apr 23, 2015
@dopplershift
Copy link
Member

Thanks for working this out!

@lewismc
Copy link
Contributor Author

lewismc commented Apr 23, 2015

no problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants