Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negation on real numbers #1246

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Negation on real numbers #1246

wants to merge 21 commits into from
+190 −0

Conversation

lowasser
Copy link
Contributor

No description provided.

@EgbertRijke
Copy link
Collaborator

Awesome!

@EgbertRijke
Copy link
Collaborator

Some formatting needs to be edited, I'll give you a more detailed review later.

@lowasser lowasser changed the title Define the negation of a real number. Negation on real numbers Jan 31, 2025
@lowasser
Copy link
Contributor Author

I've attempted to update the formatting, PR title, etc. in accordance with what you've said elsewhere.

@EgbertRijke
Copy link
Collaborator

Your code looks very good! Thank you so much for all your contributions!!

fredrik-bakke
fredrik-bakke approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request!

src/elementary-number-theory/strict-inequality-integers.lagda.md Outdated Show resolved Hide resolved
src/elementary-number-theory/strict-inequality-rational-numbers.lagda.md Outdated Show resolved Hide resolved
src/real-numbers/negation-real-numbers.lagda.md Outdated Show resolved Hide resolved
src/real-numbers/negation-real-numbers.lagda.md Outdated Show resolved Hide resolved
src/real-numbers/negation-real-numbers.lagda.md Outdated Show resolved Hide resolved
@fredrik-bakke
Copy link
Collaborator

ah, whoops, sorry for the double up review

@lowasser @fredrik-bakke @EgbertRijke
Apply suggestions from code review
2ab1490 
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
Co-authored-by: Egbert Rijke <e.m.rijke@gmail.com>
@EgbertRijke
Copy link
Collaborator

It looks like this PR just needs a make pre-commit and it has a conflict with a previous change that needs to be addressed. To do this, update your branch:

  • git pull to get any changes made in the PR here on GitHub
  • git pull origin master to get the changes from master. This will give merge conflicts.
  • Resolve the merge conflicts
  • Run make pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgbertRijke EgbertRijke EgbertRijke left review comments

@fredrik-bakke fredrik-bakke fredrik-bakke approved these changes

Assignees
No one assigned
Labels
real-numbers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowasser @EgbertRijke @fredrik-bakke