-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PurgeLinesAndUnload.py #20316
base: main
Are you sure you want to change the base?
Conversation
This change adds a setting for "minimum Z height" for the "nail down the string" moves. Update PurgeLinesAndUnload.py Bug fix. The prime blob code didn't account for the retraction at the end. This adds an 'unretract' to compensate.
d9fb042
to
acfcf6d
Compare
@HellAholic, @wawanbreton - this commit encompasses the addition of a setting for the "minimum Z height" for 'nailing down the string' as well as the bug fix for the Prime Blob code. |
Since the added lines are identical, it can be replaced with a helper function
@HellAholic you put the bug back in. You have to fix it because today is my birthday!! |
The code you added was:
This exact code is repeated 8 times, code change I added uses a helper function to put the exact same code in the same place but allows to change the gcode pattern in one place and apply it to all 8 cases. The code for
is still in the same place, that is not changed. |
Sorry, that's my bad. |
This change adds a setting for "minimum Z height" for the "nail down the string" moves.
There was an error in the "Prime Blob" code that didn't properly account for the retraction and there was no corresponding prime. This commit fixes both of those.
Description
Added a user setting for "move_to_start_min_z" so the user has an option of keeping the nozzle from actually touching down on the bed. The description for "move to start" was updated.
This fixes... OR This improves... -->
Added flexibility
Type of change
Test Configuration: Win 10 Pro and various Cura versions
Checklist: