Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-12359 write upgrade script for cura 5.10 #20315

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Feb 26, 2025

The upgrade script was already written, so this PR just polishes the new/changed settings visibility, applies the new SDK version, and converts a forgotten setting in some Method profiles.

CURA-12359

@wawanbreton wawanbreton changed the base branch from main to 5.10 February 26, 2025 07:25
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 05a5f73. ± Comparison against base commit 6833a38.

♻️ This comment has been updated with latest results.

@HellAholic HellAholic merged commit a8b4fe1 into 5.10 Feb 26, 2025
17 of 18 checks passed
@HellAholic HellAholic deleted the CURA-12359_write-upgrade-script-for-Cura-5.10 branch February 26, 2025 11:48
@rburema
Copy link
Member

rburema commented Feb 27, 2025

Note to future self(/selves): Don't forget the "setting_version" in the fdmprinter and fdmextruder files next time.

@wawanbreton
Copy link
Contributor Author

Note to future self(/selves): Don't forget the "setting_version" in the fdmprinter and fdmextruder files next time.

Maybe that would deserve a documentation with the different steps to look over ? There are a few indeed, and it is the same for every release.

@rburema
Copy link
Member

rburema commented Feb 27, 2025

Maybe that would deserve a documentation with the different steps to look over ? There are a few indeed, and it is the same for every release.

Agreed, though, if we automate (most of) it, like discussed, we also get a sort of 'documentation in action'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants