-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prime/purge tower optimisation #17971
Prime/purge tower optimisation #17971
Conversation
I made some polishing on the new settings, so it is now ready for undrafting ! It will require an upgrade script though, because I changed the setting @MariMakes would you have a few minutes to read the names and descriptions of the new settings and give me a feedback ? |
…ed-prime-tower' into optimized-prime-tower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -55,8 +55,8 @@ | |||
"settable_per_extruder": false | |||
}, | |||
"prime_blob_enable": { "default_value": false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding prime_blob_enable with the same value (default_value: False) as defined in parent definition: fdmprinter
"prime_blob_enable": { "default_value": false }, | |
@@ -44,8 +44,8 @@ | |||
"machine_width": { "default_value": 235 }, | |||
"meshfix_maximum_resolution": { "value": 0.25 }, | |||
"optimize_wall_printing_order": { "value": true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding optimize_wall_printing_order with the same value (value: True) as defined in parent definition: fdmprinter
"optimize_wall_printing_order": { "value": true }, | |
"prime_tower_min_volume": { "value": 30 }, | ||
"prime_tower_mode": { "value": "normal" }, | ||
"retract_at_layer_change": { "value": false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding retract_at_layer_change with the same value (value: False) as defined in parent definition: fdmprinter
"retract_at_layer_change": { "value": false }, | |
@@ -104,7 +104,7 @@ | |||
"default_value": false, | |||
"enabled": true | |||
}, | |||
"prime_tower_enable": { "value": "True" }, | |||
"prime_tower_mode": { "value": "normal" }, | |||
"retraction_amount": { "value": "6.5" }, | |||
"retraction_combing": { "value": "'no_outer_surfaces'" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding retraction_combing with the same value (value: no_outer_surfaces
) as defined in parent definition: ultimaker
"retraction_combing": { "value": "'no_outer_surfaces'" }, | |
See Ultimaker/CuraEngine#1875