Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prime/purge tower optimisation #17971

Merged
merged 28 commits into from
Feb 16, 2024
Merged

Prime/purge tower optimisation #17971

merged 28 commits into from
Feb 16, 2024

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton changed the title Optimized prime tower Prime/purge tower optimisation Jan 10, 2024
@wawanbreton wawanbreton added the PR: Community Contribution 👑 Community Contribution PR's label Jan 10, 2024
@wawanbreton
Copy link
Contributor Author

wawanbreton commented Jan 10, 2024

I made some polishing on the new settings, so it is now ready for undrafting !

It will require an upgrade script though, because I changed the setting prime_tower_enabled to prime_tower_mode, can you tell me if this should be part of the PR ?

@MariMakes would you have a few minutes to read the names and descriptions of the new settings and give me a feedback ?

@wawanbreton wawanbreton marked this pull request as ready for review January 10, 2024 16:26
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

@@ -55,8 +55,8 @@
"settable_per_extruder": false
},
"prime_blob_enable": { "default_value": false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding prime_blob_enable with the same value (default_value: False) as defined in parent definition: fdmprinter

Suggested change
"prime_blob_enable": { "default_value": false },

@@ -44,8 +44,8 @@
"machine_width": { "default_value": 235 },
"meshfix_maximum_resolution": { "value": 0.25 },
"optimize_wall_printing_order": { "value": true },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding optimize_wall_printing_order with the same value (value: True) as defined in parent definition: fdmprinter

Suggested change
"optimize_wall_printing_order": { "value": true },

"prime_tower_min_volume": { "value": 30 },
"prime_tower_mode": { "value": "normal" },
"retract_at_layer_change": { "value": false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retract_at_layer_change with the same value (value: False) as defined in parent definition: fdmprinter

Suggested change
"retract_at_layer_change": { "value": false },

@@ -104,7 +104,7 @@
"default_value": false,
"enabled": true
},
"prime_tower_enable": { "value": "True" },
"prime_tower_mode": { "value": "normal" },
"retraction_amount": { "value": "6.5" },
"retraction_combing": { "value": "'no_outer_surfaces'" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding retraction_combing with the same value (value: no_outer_surfaces) as defined in parent definition: ultimaker

Suggested change
"retraction_combing": { "value": "'no_outer_surfaces'" },

@wawanbreton wawanbreton added the PR: Slicing Process 🤯 Like fixing simplification, adding a new primetower, introducing tree support, correcting logging, o label Feb 16, 2024
@casperlamboo casperlamboo merged commit 32aed32 into Ultimaker:main Feb 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Slicing Process 🤯 Like fixing simplification, adding a new primetower, introducing tree support, correcting logging, o
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants