Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RatRig printers configurations #17754

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add RatRig printers configurations #17754

merged 1 commit into from
Jan 31, 2024

Conversation

Nu-hin
Copy link
Contributor

@Nu-hin Nu-hin commented Dec 23, 2023

Description

Added configurations for the following RatRig printers:

  • RatRig V-Core 3 (200mm, 300mm, 400mm, and 500mm versions)
  • RatRig V-Minion

The configurations are compatible with both V-Core 3 and 3.1 versions.

The bed meshes are taken from https://github.com/slic3r/slic3r-profiles with kind permission of the author @HelgeKeck

Type of change

  • Printer definition file(s)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (2/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (3/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (4/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (5/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (6/7)

github-actions[bot]
github-actions bot requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (7/7)

@Nu-hin Nu-hin marked this pull request as ready for review December 23, 2023 21:44
@Nu-hin
Copy link
Contributor Author

Nu-hin commented Dec 23, 2023

Pipeline fails with

Run actions-ecosystem/action-add-labels@v1
  with:
    labels: PR: Community Contribution :crown:
    github_token: ***
    repo: Ultimaker/Cura
  env:
    CONAN_LOGIN_USERNAME: ***
    CONAN_PASSWORD: ***
Error: HttpError: Resource not accessible by integration
Error: Resource not accessible by integration

Seems like it cannot assign labels to the issue, not sure if I can do anything about that.

@Nu-hin
Add RatRig printers configurations
f6cc799 
Added configurations for the following RatRig printers:

* RatRig V-Core 3 (200mm, 300mm, 400mm and 500mm versions)
* RatRig V-Minion

V-Core 3.1 modification is also supported.

Bed meshes are taken from https://github.com/slic3r/slic3r-profiles with kind permission of the author @HelgeKeck
@nallath nallath merged commit 0f0cf3e into Ultimaker:main Jan 31, 2024
@Nu-hin Nu-hin deleted the ratrig-squash branch January 31, 2024 17:33
@HellAholic
Copy link
Contributor

Hey @Nu-hin,
I see some artifacts on the print bed for one of the definitions
image
In other models they're used in the boundaries/support of the build plate
image
Also for both models (V-Core 3 200mm) and (V-Minion) the printer background seems to be loaded on top of the build plate rather than under it.
image
image

@Nu-hin
Copy link
Contributor Author

Nu-hin commented Feb 2, 2024

It seems like for V-Minion and V-Core 200mm the origin is set incorrectly (below the bed). I will try to fix it ASAP. The artifacts on the V-Minion mesh are, actually, not artifacts, but are indeed the screw holes.

@HelgeKeck
Copy link

screw holes are partly underneath the build plate

@HelgeKeck
Copy link

and the wrong z offset for the texture can only be a import error. countless users do use the exact same files for super slicer, prusa slicer, orca, ..... no issues there

@Nu-hin
Copy link
Contributor Author

Nu-hin commented Feb 2, 2024

screw holes are partly underneath the build plate

That's because Cura renders with perspective, not orthogonal projection. I rotated V-Minion in the Cura and it seems fine. The only problem is offset.

@Nu-hin Nu-hin mentioned this pull request Feb 2, 2024
Merged
1 task
@Nu-hin
Copy link
Contributor Author

Nu-hin commented Feb 2, 2024

@HellAholic I have found the issue, and submitted #18218 to fix. Thank you very much for finding and reporting the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nallath nallath nallath approved these changes

@github-actions github-actions[bot] Awaiting requested review from github-actions[bot]

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nu-hin @HellAholic @HelgeKeck @nallath