Fix NaN values on material print settings tab #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way you get sane defaults if no value is provided in the material xml file, instead of 0s
a2daac6 to
5e50a8f
Compare
|
Devs, see CURA-3037. |
LipuFei
reviewed
Apr 14, 2017
| value: parseFloat(provider.properties.value); | ||
| width: base.secondColumnWidth; | ||
| value: { | ||
| if (!isNaN(parseFloat(materialPropertyProvider.properties.value))) |
There was a problem hiding this comment.
Perhaps call parseFloat() just once? For example:
parsedValue = parseFloat(materialPropertyProvider.properties.value);
if (!isNaN(parsedValue))
...
LipuFei
approved these changes
Apr 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the print settings showing up as NaN:
See https://ultimaker.com/en/community/41810-retraction-is-nan for discussion