[CURA-9859] Account for settingfunction value that evaluates to another settingfunction. #14121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly off-topic: is the trailing underscore in arguments a new code-style standard? |
|
As far as I know, this wasn't a concise choice. It slipped past be during review. On the topic of code-style, I think we should have an internal discussion somewhere this year. I think it would make sense to adhere to Python industry standards and I think multiple team mates agree with me on this. |
|
Ah no sorry, that slipped by. I think I originally made it a local function and wanted to be sure it picked the right 'setting' variable during development. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #13675 ... at least our involvement with it. A bit worried about the other errors in that log :-/