-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): add nullish for set items #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndriesUiPath
requested review from
CatalinB7,
a team and
gheorghitahurmuz
and removed request for
a team
February 8, 2024 10:15
anbalase
reviewed
Feb 8, 2024
projects/angular/components/ui-grid/src/filters/ui-grid-dropdown-filter.directive.ts
Outdated
Show resolved
Hide resolved
CatalinB7
previously approved these changes
Feb 8, 2024
AlexAndriesUiPath
force-pushed
the
fix/grid-dropdown-filter
branch
from
February 8, 2024 10:19
16e333c
to
3fa5761
Compare
CatalinB7
reviewed
Feb 8, 2024
projects/angular/components/ui-grid/src/filters/ui-grid-dropdown-filter.directive.ts
Show resolved
Hide resolved
toxik
previously approved these changes
Feb 8, 2024
AlexAndriesUiPath
force-pushed
the
fix/grid-dropdown-filter
branch
from
February 8, 2024 10:27
3fa5761
to
95903cf
Compare
CatalinB7
previously approved these changes
Feb 8, 2024
AlexAndriesUiPath
force-pushed
the
fix/grid-dropdown-filter
branch
from
February 8, 2024 11:22
95903cf
to
a25b3eb
Compare
Code Climate has analyzed commit a25b3eb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.3% (0.0% change). View more on Code Climate. |
CatalinB7
approved these changes
Feb 8, 2024
gheorghitahurmuz
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.