Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation related issues and improve the swipe performance #149

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

UdaySravanK
Copy link
Owner

@UdaySravanK UdaySravanK commented Feb 2, 2025

Instead of every container width change goes through an animation with a duration, divide into 2 parts. While swipe is in progress, we use 0 duration all the time and for the animations we use the provided or default value i.e. 400ms. This will also fix the swipe thumb frozen in the middle on real devices.

Before changes After changes
Screen_recording_20250201_222801.mp4
Screen_recording_20250201_222917.mp4

Test Coverage

Screenshot 2025-02-01 at 22 33 26

…h a duration, divide into 2 parts. While swipe is in progress, we use 0 duration all the time and for the animations we use the provided or default value i.e. 400ms. This will also fix the swipe thumb frozen in the middle on real devices.
@UdaySravanK UdaySravanK merged commit 27d7b8b into master Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant