Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artifact uploads #9

Merged
merged 13 commits into from
Dec 1, 2021
Merged

Add artifact uploads #9

merged 13 commits into from
Dec 1, 2021

Conversation

wfondrie
Copy link
Collaborator

@wfondrie wfondrie commented Dec 1, 2021

This PR adds previews of our release artifacts for inspection.

@wfondrie
Copy link
Collaborator Author

wfondrie commented Dec 1, 2021

After some digging, I finally decided to print secrets.COMET_LICENSE. Alas, it was empty, which seems to be the problem here.

@wfondrie
Copy link
Collaborator Author

wfondrie commented Dec 1, 2021

@mammmals want to take a final look and merge if its good?

mammmals
mammmals approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@mammmals mammmals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, build artifacts seem to be intact. PW should be removed at future time.

@mammmals mammmals merged commit f77e2bc into UWPR:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mammmals mammmals mammmals approved these changes

Assignees

@mammmals mammmals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfondrie @mammmals