-
Notifications
You must be signed in to change notification settings - Fork 6
Update Packages, Use Chrome to test, User Prettier to Format #25
Update Packages, Use Chrome to test, User Prettier to Format #25
Conversation
set prettier defaults to better match eslint config.
Requested in uPortal-Attic/uportal-app-framework#580 (comment) |
/reviewers @davidmsibley @vertein @thevoiceofzeke @apetro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still uneasy about things that are auto-formatting code built into the process. I would be in favor of having the script available, but not as part of the commit process.
I'd encourage giving it a try. Take a look at the format commit 0042254.
the
uPortal-Attic/uportal-app-framework#580 (comment) This version will exactly follow Google code style.
uPortal-Attic/uportal-app-framework#580 (comment) Widget creator was suggested as a proving ground for the uPortal-app-framework team to be able to try this process out and see if its a good fit for the team dynamic. edit corrected typos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it.
🔔 I don't have write access to this repo, if/when the team decides to merge this, someone other than me would need to click the merged button. |
Updates all the dependencies
package.json
.Replace Phantom JS with Chrome/Puppeteer.
Use ESLint Prettier to apply Prettier formatting and ESLint analysis together.