-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevented CommunicationTxTask from accessing mutex before its declared #219
Open
SnakeEgg
wants to merge
11
commits into
operations/new-communications-tasks
Choose a base branch
from
operation/communication-mutex-logic
base: operations/new-communications-tasks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prevented CommunicationTxTask from accessing mutex before its declared #219
SnakeEgg
wants to merge
11
commits into
operations/new-communications-tasks
from
operation/communication-mutex-logic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated return codes for FRAM, I2C, and UART wrappers * updated readme to reflect updates to error code standards * removed a dumb whitespace char between function name and its inputs * updated README section on data types * added a word * another update * wuick commit * Added stub header files for Antenna, EPS, Trx. No API, just I2C slave addrs * creatd the camera header file * Source code of the camera function * Working progress on sending telecommand to the camera to take an image * deleted redundant files left over from the merge' * In progress we added string.h * working progress on defining telecommands and their parameters * Added Telemetry frames * Writing telecommands is completed. No errors with telecommands.Still working on telemetry format * Changed up telemetry approach, added defines * continued working on the telemetry's * finsihed telemetry functions for camera * added a TODO for the telemetry tasks * Added filtering function to filter out useless images. Added some code to capture and filter * Added RImage.c and .h -> added all TC and TLMs with defines * added RADCS files and included libraries in RImage.c * RImage.h is updated. Image processing function is moved to RI * finished revision A for RImage and RADCS and re-established a base for RCamera * finished all tc and tlm functions, ready to creating functions * made the adcs function and it has a clean build * camera.c and image.c is updated. Capture and download function is also updated. * Cleaned up the code a bit and and finished telemetry function * image processing function updated * finish the config function and download function * Finished the capture and filtering functions * added error to return instead of SUCCESS * general touch up * for loop for average grayScale of one frame * initial grayScale filter, previous implementation in comments * added if statements to check overall average in a range * changed function name to SaturationFilter * addeed a hex to dec converter and used it in the saturation filter * styling corrections * changed the range for the filter * added error check and made minor styling changes * made changes to pointers of arrays that were causing issues * syntax clean up for PR * resolved all errors and warnings on build * added comments, removed TODOs * changed full image struct to not define a pointer but an array instead, giving clean build * fixed saturation filter with indexing and made style changes * fixed some typos and pointers; started to tackle detection function * improved code to capture & download image, and for the camera detection algorithm; fixed some potential memory leaks * fixed imageFrame pointer issue; removed risky malloc cast * fixed the detection calculation to return floating point results * fixed major camera/UART issue by escaping & unescaping characters (see ICD); cleaned up code by moving common definitions & functions in a new file (RCameraCommon) * optimized code by removing duplication; removed unused definitions and fixed typos * allocated image memory dynamically based on size; moved size and frame count in image struct * added parameters to captureImage; added retry given unscheduled detection results; renamed some functions * added a reset function * added comments pointing to which camera functions to use Co-authored-by: tyrelkostyk <tck290@mail.usask.ca> Co-authored-by: Shiva Moghtaderi <moghtaderishiva@gmail> Co-authored-by: Addi Amaya <chris.amaya.caa@gmail.com> Co-authored-by: Addi Amaya <caa746@usask.ca> Co-authored-by: Atharva <you@example.com> Co-authored-by: Austin <maxwellman123@gmail.com> Co-authored-by: w-moretti <=> Co-authored-by: William Moretti <maleck3@hotmail.com>
A commit message that would make Makaroff cry |
* started implementation of data storage in FRAM * allocated 2 bytes for cursors in FRAM; started read implementation * finished implementation of FRAM in FileTransferService * removed unnecessary code * Update radsat-sk/operation/services/RFileTransferService.c Co-authored-by: Austin <Austin.Hruska@usask.ca> * removed shared variables and implemented a reset function for the file transfer in FRAM Co-authored-by: Austin <Austin.Hruska@usask.ca> Co-authored-by: William Moretti <=>
* Added CameraService & refactored camera code to fit use cases. Fixed uart receive issue during large image download. * improved image frame format for downlink; changed image frame index to circular buffer; added functions to set & get flags * added missing flags to prevent usage of cubesense while busy * removed testing code and unecessary comments Co-authored-by: w-moretti <=>
* Refactorying and adding files and code for test suite * Include testing and moved test suite to testing * Changed to remove testing file from compiling for debug and release. Setup UI as well. * Fix test UI, added unfinished dosimeter test, fixed project file bugs, added launch config. * Added debugReadIntMinMax so that user input dosn't block the watchdog * Added CR and DEL definitions * Initial implementation of general test exicution with GUI * Fixes and extend tests to dosimeter * Fixed mainTestMenuTask return non-null value and ending function with vTaskDelete * Event more dumb fixes * Fixed old issues * more old issues fixed * Final touched before pull * Remove Demo files --------- Co-authored-by: brian <brp240@usask.ca>
* Adding battery test file * Changes and updates to TestUtiles and TestSuite * Fix many errors/bugs/warnings
…work also lots of debug functions added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.