Skip to content

Commit

Permalink
Fix/container spacing (#71)
Browse files Browse the repository at this point in the history
* fix: fluid-container padding size on mobile

* fix: replace values in _application.scss with variables

* fix: remove upper limit in _container.scss media query
  • Loading branch information
dannyk3941 authored Sep 26, 2023
1 parent a09110b commit c38bfa6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
13 changes: 6 additions & 7 deletions packages/vanilla/src/sass/components/header/_application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@
@mixin menu-hover {
color: var(--cbp-color-text-darkest);
background-color: var(--cbp-color-interactive-secondary-lighter);
//border-style: solid;
border-color: var(--cbp-color-interactive-secondary-darker);
//border-width: 0 0 var(--cbp-border-size-md) 0;
}

.cbp-application-header {
display: flex;
align-items: center;
height: 56px;
height: var(--cbp-space-14x);
width: 100%;
position: sticky;
top: -1px;
top: calc(-1 * var(--cbp-space-half-x));
background-color: var(--cbp-color-white);
box-shadow: 0px 5px 5px -3px var(--cbp-color-interactive-secondary-dark);
box-shadow: var(--cbp-shadow-level-1-down);
padding-right: var(--cbp-space-4x);
z-index: var(--cbp-z-index-level-1);

Expand Down Expand Up @@ -62,7 +60,7 @@
border-width: 0 0 var(--cbp-border-size-md) 0;

& > i {
margin-left: 8px;
margin-left: var(--cbp-space-2x);
}

&:hover {
Expand All @@ -82,7 +80,8 @@
.nav-home {
font-size: var(--cbp-font-size-heading-sm);
font-weight: var(--cbp-font-weight-bold);
padding: 0 var(--cbp-space-4x) 0 var(--cbp-space-4x);
padding-left: var(--cbp-space-5x);
padding-right: var(--cbp-space-5x);
}
}

Expand Down
6 changes: 3 additions & 3 deletions packages/vanilla/src/sass/layout/_container.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@use './../tokens/breakpoints' as *;

.cbp-fluid-container {
padding-left: var(--cbp-space-4x);
padding-right: var(--cbp-space-4x);
padding-left: var(--cbp-space-5x);
padding-right: var(--cbp-space-5x);

@media (min-width: $cbp-breakpoint-md) and (max-width: $cbp-breakpoint-xl) {
@media (min-width: $cbp-breakpoint-md) {
padding-left: var(--cbp-space-8x);
padding-right: var(--cbp-space-8x);
}
Expand Down

0 comments on commit c38bfa6

Please sign in to comment.