Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary echo $output line from cleaning tests #1

Closed
NicMcPhee opened this issue Aug 27, 2016 · 1 comment
Closed

Remove unnecessary echo $output line from cleaning tests #1

NicMcPhee opened this issue Aug 27, 2016 · 1 comment

Comments

@NicMcPhee
Copy link
Contributor

I left what was essentially a print statement in the tests for the "cleaning" part of the lab. This breaks things for students who try to run the tests on a machine that someone else has run the tests on. The first person to run the tests creates a /tmp/output file and leaves it behind, and when the second person tries to overwrite that file, it turns out that they don't have permission to do so, and the test script fails as a result.
@NicMcPhee
Copy link
Contributor Author

Fixed via commit 22fbcc2 courtesy of @dstelljes.

NicMcPhee added a commit that referenced this issue Aug 28, 2016
@NicMcPhee
Merge pull request #1 from mcphee/master
ad7177a 
README: Updates compiling to clarify directory structure
NicMcPhee added a commit that referenced this issue Aug 28, 2016
@NicMcPhee
Fix problem with "cleaning" tests. (#1)
f8da2d0 
* Tweaked archive contents test to normalize order

* Removed /tmp/output write from cleaning tests
NicMcPhee added a commit that referenced this issue Aug 28, 2016
@NicMcPhee
Merge pull request #3 from mcphee/master
61acc7e 
Fix problem with "cleaning" tests. (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NicMcPhee