-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NPM@3 and node 4.4.2 and 6 #61
base: master
Are you sure you want to change the base?
Conversation
joefitter
commented
Jun 6, 2016
•
edited
Loading
edited
- updated .travis.yml to check version of npm, install @3 if < 3
- run CI using node 4.4.2 and 6
LGTM, @easternbloc, @daniel-ac-martin |
Shouldn't we just test on node v4 (rather than 4.4.2) and v6. Does anyone know the reason for needing npm v3? (And when this dependency was introduced. - I'm guessing HOF v7.) |
perhaps, but the current node base image uses 4.4.2 |
An update to one of the many deps (not sure which) uses postinstall, which fails now because it's dependency is not installed first |
@JoeChapman: Ah okay. I forgot that this project has a Dockerfile. |
@joefitter probably removed all bar 2 versions because travis can only run 2 builds concurrently. More version === more time spent testing/building |
@JoeChapman In that case could we replace v5 with v6. That should at least catch more problems. |
@joefitter ^^ |
Yep - happy with that |
* updated .travis.yml to check version of npm, install @3 if < 3 * run CI using node 4.4.2 and 6
Need to update node-sass to 3.7.0 as per sass/node-sass#1484 |