Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NPM@3 and node 4.4.2 and 6 #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use NPM@3 and node 4.4.2 and 6 #61

wants to merge 1 commit into from

Conversation

joefitter
Copy link
Contributor

@joefitter joefitter commented Jun 6, 2016

  • updated .travis.yml to check version of npm, install @3 if < 3
  • run CI using node 4.4.2 and 6

@JoeChapman
Copy link
Contributor

LGTM, @easternbloc, @daniel-ac-martin

@daniel-ac-martin
Copy link
Collaborator

Shouldn't we just test on node v4 (rather than 4.4.2) and v6.
i.e. The latest of each.

Does anyone know the reason for needing npm v3? (And when this dependency was introduced. - I'm guessing HOF v7.)

@JoeChapman
Copy link
Contributor

JoeChapman commented Jun 6, 2016

Shouldn't we just test on node v4 (rather than 4.4.2) and v6.
i.e. The latest of each.

perhaps, but the current node base image uses 4.4.2

@JoeChapman
Copy link
Contributor

JoeChapman commented Jun 6, 2016

Does anyone know the reason for needing npm v3? (And when this dependency was introduced. - I'm guessing HOF v7.)

FormidableLabs/builder#35

An update to one of the many deps (not sure which) uses postinstall, which fails now because it's dependency is not installed first

@daniel-ac-martin
Copy link
Collaborator

@JoeChapman: Ah okay. I forgot that this project has a Dockerfile.
Would still be nice to test against the latest v4 anf v6 though. (Do we care about v5?)

@JoeChapman
Copy link
Contributor

@joefitter probably removed all bar 2 versions because travis can only run 2 builds concurrently. More version === more time spent testing/building

@daniel-ac-martin
Copy link
Collaborator

@JoeChapman In that case could we replace v5 with v6. That should at least catch more problems.

@JoeChapman
Copy link
Contributor

@joefitter ^^

@joefitter
Copy link
Contributor Author

Yep - happy with that

@joefitter joefitter changed the title Use NPM@3 and node 4.4.2 and 5 Use NPM@3 and node 4.4.2 and 6 Jun 6, 2016
* updated .travis.yml to check version of npm, install @3 if < 3
* run CI using node 4.4.2 and 6
@JoeChapman
Copy link
Contributor

JoeChapman commented Jun 6, 2016

Need to update node-sass to 3.7.0 as per sass/node-sass#1484

@joefitter
Copy link
Contributor Author

#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants