Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with updated dependencies #19

Merged
merged 10 commits into from
Jul 5, 2021

Conversation

myoung-ukcloud
Copy link
Contributor

Updated rust to fix build and merged in dependabot PRs

With rust 1.41 the build was failing with errors such as:

#14 28.26 error[E0658]: use of unstable library feature 'matches_macro'
#14 28.26 --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/tracing-core-0.1.18/src/event.rs:104:9
#14 28.26 |
#14 28.26 104 | matches!(self.parent, Parent::Root)
#14 28.26 | ^^^^^^^
#14 28.26 |
#14 28.26 = note: for more information, see rust-lang/rust#65721
#14 28.26

According to the following pages this is due to a minimum requirement of rust 1.42
  • https://github.com/rust-lang/rust/issues/65721
    
  • https://github.com/diem/diem/issues/3558
    

    Updated to almost latest rust 1.51. 1.52 was released today but is not available in the docker repository

dependabot bot and others added 9 commits January 6, 2021 11:59
Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](axios/axios@v0.19.2...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>
With rust 1.41 the build was failing with errors such as:

According to the following pages this is due to a minimum requirement
of rust 1.42

rust-lang/rust#65721
diem/diem#3558

Updated to almost latest rust 1.51. 1.52 was released today but
is not available in the docker repository
@suehighmoor suehighmoor removed their request for review May 17, 2021 08:34
@suehighmoor
Copy link

Just removing myself from the list of reviewers, as I don't think I have the appropriate skillset to provide any meaningful feedback and don't want to delay anything...

@bensaunders bensaunders merged commit b1dcee1 into master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants