Skip to content

Commit

Permalink
Merge branch 'main' into feat/APIM-610
Browse files Browse the repository at this point in the history
  • Loading branch information
Abhi Markan committed Dec 16, 2024
2 parents f1bfff4 + 5f3d787 commit 9ced798
Show file tree
Hide file tree
Showing 12 changed files with 918 additions and 692 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ on:
- production

paths:
- "src/**"
- "package.json"
- "package-lock.json"
- "Dockerfile"
- "tsconfig.json"
- "tsconfig.build.json"
- ".github/workflows/deployment.yml"
- 'src/**'
- 'package.json'
- 'package-lock.json'
- 'Dockerfile'
- 'tsconfig.json'
- 'tsconfig.build.json'
- '.github/workflows/deployment.yml'

env:
PRODUCT: apim
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/github.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
branches: [main, main-*]

env:
environment: "qa"
environment: 'qa'
TIMEZONE: ${{ vars.TIMEZONE }}

jobs:
Expand Down
82 changes: 63 additions & 19 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,8 @@
# Sets the timezone using the specified value.
# Checks out the repository code.
# Sets up the specified Node.js version.
# Installs dependencies using npm run ci:all.
# Runs linting using the command npm run lint
#
# Prettier:
# Name: Prettier
# Depends on: setup
# Runs on: ubuntu-latest
# Steps:
# Sets the timezone using the specified value.
# Checks out the repository code.
# Sets up the specified Node.js version.
# Installs dependencies using npm run ci:all.
# Runs prettier using the command npm run prettier.
# Installs dependencies using npm ci --legacy-peer-deps.
# Runs linting using the command npm run lint:all.
#
# Key Points:
# The workflow focuses on linting, which checks code for potential errors, style issues, and adherence to best practices.
Expand All @@ -46,14 +35,13 @@ run-name: 🎨 Lint checking on ${{ github.event.number }}

on:
pull_request:
branches: [main]
paths:
- "src/**"
- "test/**"
branches:
- main
- 'release-*'

env:
environment: "qa"
TIMEZONE: ${{ vars.TIMEZONE }}
environment: 'qa'
timezone: ${{ vars.TIMEZONE }}

jobs:
# 1. Setup test infrastructure
Expand Down Expand Up @@ -125,3 +113,59 @@ jobs:
- name: Linting
working-directory: ./
run: npm run prettier

# 4. Type check
typecheck:
name: TypeScript ⌨️
environment:
name: ${{ needs.setup.outputs.environment }}
runs-on: ubuntu-latest
steps:
- name: Timezone
uses: szenius/set-timezone@v2.0
with:
timezoneLinux: ${{ needs.setup.outputs.timezone }}

- name: Repository
uses: actions/checkout@v4

- name: Node
uses: actions/setup-node@v4
with:
node-version: ${{ vars.NODE_VERSION }}

- name: Dependencies
working-directory: ./
run: npm ci --legacy-peer-deps

- name: Validate
working-directory: ./
run: npm run type-check

# 5. YAML check
yaml:
name: YAML ⌨️
environment:
name: ${{ needs.setup.outputs.environment }}
runs-on: ubuntu-latest
steps:
- name: Timezone
uses: szenius/set-timezone@v2.0
with:
timezoneLinux: ${{ needs.setup.outputs.timezone }}

- name: Repository
uses: actions/checkout@v4

- name: Node
uses: actions/setup-node@v4
with:
node-version: ${{ vars.NODE_VERSION }}

- name: Dependencies
working-directory: ./
run: npm ci --legacy-peer-deps

- name: Validate
working-directory: ./
run: npm run validate:yml
12 changes: 6 additions & 6 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ run-name: 🔎 Pull request analysis on ${{ github.event.number }}

on:
schedule:
- cron: "00 00 * * *"
- cron: '00 00 * * *'
env:
environment: "qa"
environment: 'qa'
TIMEZONE: ${{ vars.TIMEZONE }}

jobs:
Expand Down Expand Up @@ -46,8 +46,8 @@ jobs:
uses: actions/stale@v9
with:
days-before-pr-stale: ${{ vars.STALE_PR_DAYS }}
stale-pr-message: "Pull request marked as stale due to inactivity."
stale-pr-label: "Stale"
stale-pr-message: 'Pull request marked as stale due to inactivity.'
stale-pr-label: 'Stale'
days-before-pr-close: ${{ vars.CLOSE_PR_DAYS }}
close-pr-message: "Pull request has been closed due to inactivity."
close-pr-label: "Closed"
close-pr-message: 'Pull request has been closed due to inactivity.'
close-pr-label: 'Closed'
2 changes: 1 addition & 1 deletion .github/workflows/sca.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
branches: [main]

env:
environment: "qa"
environment: 'qa'
TIMEZONE: ${{ vars.TIMEZONE }}

jobs:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ run-name: Executing test QA on ${{ github.repository }} 🚀

on:
pull_request:
branches: [main]
paths:
- "**"
branches:
- main
- 'release-*'

env:
environment: "qa"
environment: 'qa'
TIMEZONE: ${{ vars.TIMEZONE }}

jobs:
Expand Down
Loading

0 comments on commit 9ced798

Please sign in to comment.