Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deleted custom cards #1561

Closed
wants to merge 4 commits into from

Conversation

wilbiev
Copy link
Collaborator

@wilbiev wilbiev commented Dec 14, 2024

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: restore original custom cards deleted with previous pull request
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

@wilbiev wilbiev self-assigned this Dec 14, 2024
@wilbiev
Copy link
Collaborator Author

wilbiev commented Dec 14, 2024

@iganeshk can you please review this request? This request restores some custom cards which were accidently deleted in the release repo.

@wilbiev
Copy link
Collaborator Author

wilbiev commented Dec 20, 2024

@warmfire540: please review this PR. With this correction I can sync main with release again. Thanks!

Copy link
Contributor

@warmfire540 warmfire540 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️ they're back now

@warmfire540
Copy link
Contributor

@wilbiev nm - i'm not an approving reviewer... one day 👍

@KruseLuds
Copy link

What testing is being done on these releases... lol....?

@wilbiev
Copy link
Collaborator Author

wilbiev commented Dec 21, 2024

@KruseLuds good point! There were updated custom cards which I thought I could remove from my PR for repo release. Updated custom cards should be merged with repo main not release. Did not expect they would be actually deleted from the repo. Beginner mistake.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilbiev wilbiev closed this Dec 21, 2024
@wilbiev wilbiev deleted the wilbie-fix-4 branch December 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants