Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve yaml.load() deprecations #224

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Resolve yaml.load() deprecations #224

merged 1 commit into from
Apr 26, 2020

Conversation

smmaurer
Copy link
Member

This PR resolves yaml.load() deprecations, as described in issue #216.

Changes

Replaces all instances of yaml.load() with yaml.safe_load(), except where a Loader=... argument is provided.

Potential compatibility issues

yaml.safe_load() prevents arbitrary Python data types from being encoded and decoded from yaml. Since our use case here is specifically to store dictionary representations of model specifications, I don't see this being an issue.

See additional discussion in issue #216.

@smmaurer smmaurer requested a review from sablanchard April 22, 2020 22:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.196% when pulling 44ca1d4 on yaml-deprecations into 84e7d3f on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants