Change usages of datetime.date to tlo.Date in lifestyle module
#944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Final population dataframes after a 12 month run of |
tamuri
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.dateinstances are being used in various places insrc/tlo/methods/enhanced_lifestyle.pyto set start dates of campaigns rather thantlo.Date == pandas.Timestampinstances, which I think is hitting against issue described in #934 and causing differences in population dataframe when simulating with Pandas v1.2.2 and v2.0.0 described in #763 (comment). Will re-run thescale_run.pysimulations with this change to see if it removes differences in population dataframes and then report back.