Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseITK upstream issue: ITK is added to the global include path #432

Closed
rijobro opened this issue Nov 29, 2019 · 1 comment · Fixed by #1536
Closed

UseITK upstream issue: ITK is added to the global include path #432

rijobro opened this issue Nov 29, 2019 · 1 comment · Fixed by #1536
Assignees
@KrisThielemans
Labels
Upstream fix required wontfix

Comments

@rijobro
Copy link
Collaborator

rijobro commented Nov 29, 2019

I've created an issue on ITK (InsightSoftwareConsortium/ITK#1450) flagging up the use of include_directories and link_directories in UseITK.cmake.

Can't imagine it'll be a quick fix (if at all), but we'll see what they say.
@KrisThielemans KrisThielemans mentioned this issue Apr 14, 2020
Open
@KrisThielemans KrisThielemans changed the title UseITK upstream issue UseITK upstream issue: ITK is added to the global include path Oct 1, 2024
@KrisThielemans KrisThielemans self-assigned this Oct 1, 2024
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Oct 1, 2024
@KrisThielemans
no longer add ITK to global path in exported CMake
42743e6 
It turns out that we don't need `include(${ITK_USE_FILE})` in
STIRConfig.cmake. This therefore avoids adding the ITK include directory
to the global include path.

Effectively fixes UCL#432 as when building STIR, we don't mind (currently
anyway).
@KrisThielemans
Copy link
Collaborator

This can cause problems for SIRF etc or others who include STIR via CMake as the ITK include directory is therefore added to the global include path

STIR/src/cmake/STIRConfig.cmake.in

Line 82 in 6417022

include(${ITK_USE_FILE})

Internally, we don't mind that the ITK include path added for all files (currently anyway).

However, it turns out that we don't need include(${ITK_USE_FILE}) in STIRConfig.cmake (see #1518). While InsightSoftwareConsortium/ITK#1450 suggests some ways to circumvent the ITK_USE_FILE problem, updating STIRConfig.cmake solves most problems, so I won't fix this.

@KrisThielemans KrisThielemans mentioned this issue Oct 1, 2024
Open
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Oct 1, 2024
@KrisThielemans
no longer add ITK to global path in exported CMake
18d4b4e 
It turns out that we don't need `include(${ITK_USE_FILE})` in
STIRConfig.cmake. This therefore avoids adding the ITK include directory
to the global include path.

Effectively fixes UCL#432 as when building STIR, we don't mind (currently
anyway).
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Nov 14, 2024
@KrisThielemans
[CMake] improve exported config
dc2640f 
- find_package Boost REQUIRED as its include files are needed
- remove ITK_USE_FILE as not needed

Fixes UCL#432
@KrisThielemans KrisThielemans mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
Upstream fix required wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve CMake library dependencies KrisThielemans/STIR-1
2 participants
@KrisThielemans @rijobro