Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MuonCalibrator to follow MCP recommendations for AB>=21.2.198 #1525

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

jbossios
Copy link
Contributor

@jbossios jbossios commented Feb 18, 2022

MCP introduced in 21.2.198 a new property (calibrationMode) which by default is "noOption" which would make the tool crash. The same functionality is implemented here, forcing the user to pick up one of the supported ones ("correctData_CB", "correctData_IDMS" or "notCorrectData_IDMS") through m_calibrationMode.

I have also switched to using MuonCalibrationPeriodTool, instead of MuonCalibrationAndSmearingTool, which sets all properties automatically for the corresponding data year / MC campaign. All previous options were removed (some if not all of them are not supported in the PeriodTool), but if some of them are still needed (for expert usage) we could consider adding back the option to use the MuonCalibrationAndSmearingTool in a future PR (through a switch such that PeriodTool is the default).

IMPORTANT: This will make xAH::MuonCalibrator not to work on AB<21.2.198. I recommend making a tag for those wanting to stay on <21.2.198 and make 21.2.198 he minimum release for master. @kratsg: what do you think?

MCP twiki: https://twiki.cern.ch/twiki/bin/view/AtlasProtected/MCPAnalysisGuidelinesMC16

This should replace #1524

@kratsg
Copy link
Contributor

kratsg commented Feb 18, 2022

IMPORTANT: This will make xAH::MuonCalibrator not to work on AB<21.2.198. I recommend making a tag for those wanting to stay on <21.2.198 and make 21.2.198 he minimum release for master. @kratsg: what do you think?

Let's make a tag, or at least refer to the commit. You'll also need to update the github actions workflow for the supported versions in this PR -- seems we're dropping all but 21.2.198+

@jbossios
Copy link
Contributor Author

@kratsg I updated ci.yml to use +21.2.198. I don't seem to have permissions to create a tag.

@kratsg
Copy link
Contributor

kratsg commented Feb 22, 2022

@kratsg I updated ci.yml to use +21.2.198. I don't seem to have permissions to create a tag.

I'll create a tag. Just give me the command I guess?

@kratsg
Copy link
Contributor

kratsg commented Feb 22, 2022

https://github.com/UCATLAS/xAODAnaHelpers/releases/tag/v1.1.0 is drafted. Merging this now.

@kratsg kratsg merged commit 0e89d7d into UCATLAS:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants