Update MuonCalibrator to follow MCP recommendations for AB>=21.2.198 #1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP introduced in 21.2.198 a new property (calibrationMode) which by default is "noOption" which would make the tool crash. The same functionality is implemented here, forcing the user to pick up one of the supported ones ("correctData_CB", "correctData_IDMS" or "notCorrectData_IDMS") through m_calibrationMode.
I have also switched to using MuonCalibrationPeriodTool, instead of MuonCalibrationAndSmearingTool, which sets all properties automatically for the corresponding data year / MC campaign. All previous options were removed (some if not all of them are not supported in the PeriodTool), but if some of them are still needed (for expert usage) we could consider adding back the option to use the MuonCalibrationAndSmearingTool in a future PR (through a switch such that PeriodTool is the default).
IMPORTANT: This will make xAH::MuonCalibrator not to work on AB<21.2.198. I recommend making a tag for those wanting to stay on <21.2.198 and make 21.2.198 he minimum release for master. @kratsg: what do you think?
MCP twiki: https://twiki.cern.ch/twiki/bin/view/AtlasProtected/MCPAnalysisGuidelinesMC16
This should replace #1524