-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to bind to specific network interfaces via Thunderscope #3235
Conversation
Actually the error goes away when I delete my |
Yeah that's a known issue whenever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM very nice!
* | ||
* @return true if the IP address was found, false otherwise | ||
*/ | ||
bool getLocalIp(const std::string& interface, std::string& ip_address, bool ipv4 = true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could return std::optional<std::string>
to avoid the out parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated
Closed in favour of #3417 |
Description
Summary of changes:
How can you test?
Play around with
./tbots.py run thunderscope_main --run_blue --run_diagnostics --disable_communcation
Testing Done
At home with different gamecontroller instances on my home network. The video binds to my local interface first, then an interface that isn't connected to a network and then a home interface that had a gamecontroller instance on it.
IMG_0028.mp4
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issue