Fix: Competition current threshold modification #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Regulation 8.3.B states:
The "OR" statement at the end of this regulation caused us to have issues at scruitineering. We assumed that the over-temperature charge limit would be a trip, and that the over-temperature discharge limit would be a fault. However, the scruitineers required us to have a fault at 45C (trip at 44C), and a fault at 65C (whereas before, we just had the trip at 45C and fault at 65C).
They argue that this because, when you exceed any of the manufactuer's specifications, you should fault the pack. Thus, even though you're opening HLIM when you trip at 44C and requesting regen off (meaning you'd never reach 45C while charging), you still need to trip at 45C.
BMS FW was changed to trip at 44C, and a fault was added at 45C with an additional check on the current direction of the ECU current (which we get from the ECU's CAN current field). The 65C fault was unchanged. There was no additional CAN bit that was set for this.
See updated ECU status code ref: https://docs.google.com/spreadsheets/d/1xxisHuuusQCDnes3OIaucntGGlHj25iUrbfAIXvNhaM/edit?gid=0#gid=0
Monday Link
Effected Components
Testing
Sanity check
Sources