Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Competition current threshold modification #151

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

mjohal67
Copy link
Contributor

@mjohal67 mjohal67 commented Jul 15, 2024

Pull Request Description

Regulation 8.3.B states:

All lithium based battery packs must have active protection such that over-voltage,
over-temperature (for charge and discharge rating), over-current and under-voltage cause the Main
Power Switch per 8.6.A to open and to electrically isolate the source or sink for the vehicle.

The "OR" statement at the end of this regulation caused us to have issues at scruitineering. We assumed that the over-temperature charge limit would be a trip, and that the over-temperature discharge limit would be a fault. However, the scruitineers required us to have a fault at 45C (trip at 44C), and a fault at 65C (whereas before, we just had the trip at 45C and fault at 65C).

They argue that this because, when you exceed any of the manufactuer's specifications, you should fault the pack. Thus, even though you're opening HLIM when you trip at 44C and requesting regen off (meaning you'd never reach 45C while charging), you still need to trip at 45C.

BMS FW was changed to trip at 44C, and a fault was added at 45C with an additional check on the current direction of the ECU current (which we get from the ECU's CAN current field). The 65C fault was unchanged. There was no additional CAN bit that was set for this.

See updated ECU status code ref: https://docs.google.com/spreadsheets/d/1xxisHuuusQCDnes3OIaucntGGlHj25iUrbfAIXvNhaM/edit?gid=0#gid=0

Monday Link

Effected Components

  • AMB
  • BMS
  • DID
  • ECU
  • MCB
  • MDI
  • TEL
  • CI/CD

Testing

  • Vehicle testing
  • Bench top testing
  • Unit testing
  • Other (Comp 2024 scruitineering)
  • N/A

Sanity check

  • CAN ID table updated
  • IOC updated and commited
  • gitignore updated and commited
  • Steps confirmed

Sources

@ishanjoshi23 ishanjoshi23 changed the title User/mjohal67/ecu comp current threshold Fix: Competition current threshold modification Jul 18, 2024
Copy link
Contributor

@ishanjoshi23 ishanjoshi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove AMB changes

Copy link
Contributor

@ishanjoshi23 ishanjoshi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the extra files added here

@ishanjoshi23 ishanjoshi23 merged commit 9a209c4 into master Jul 18, 2024
1 check failed
@ishanjoshi23 ishanjoshi23 deleted the user/mjohal67/ecu_comp_current_threshold branch July 18, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants