Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify audio stream languages #845

Closed
4 of 6 tasks
grabthefish opened this issue Nov 28, 2024 · 0 comments · Fixed by #847
Closed
4 of 6 tasks

Identify audio stream languages #845

grabthefish opened this issue Nov 28, 2024 · 0 comments · Fixed by #847

Comments

@grabthefish
Copy link

Version

v6.4.4

Platform

.NET 8 / Windows 11

Steps to reproduce

When trying to download a video with audio streams in multiple loanguages we can't see which stream is in which language
for example https://www.youtube.com/watch?v=ngqcjXfggHQ has audio tracks in 5 different languages so when selecting a track to download it's like rolling a dice
image

Details

the language of an audio track/stream and whether it's the default language gets downloaded in the manifest json and should probably be added to IAudioStreamInfo

"adaptiveFormats": [
    ...
 
  {
    ...
    "audioTrack": {
      "displayName": "Portuguese (Brazil)",
      "id": "pt-BR.10",
      "audioIsDefault": false
    }
    ...
  },
  {
    ...
    "audioTrack": {
      "displayName": "English (United States) original",
      "id": "en-US.4",
      "audioIsDefault": true
    },
    ...
  }

Checklist

  • I have looked through existing issues to make sure that this bug has not been reported before
  • I have provided a descriptive title for this issue
  • I have made sure that this bug is reproducible on the latest version of the package
  • I have provided all the information needed to reproduce this bug as efficiently as possible
  • I have sponsored this project
  • I have not read any of the above and just checked all the boxes to submit the issue
@Tyrrrz Tyrrrz changed the title Audio streams of different languages get downloaded Identify audio stream languages Dec 2, 2024
Tyrrrz added a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants