fix: use the bash executable specified by PATH #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the release script so the final bashunit script will use PATH to find bash. The version of bash in /bin on macOS is very old, and forcing tests to use it is quite limiting.
|
This seems like a workable approach, but I'm not sure it's best (especially because there don't appear to be any tests that use the final packaged Happy to get any feedback on this change in general as well. |
|
Everything seems to be working fine. Thanks for the PR, @apotterri !
|
Chemaclass
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Update the release script so the final bashunit script will use PATH to find bash. The version of bash in /bin on macOS is very old, and forcing tests to use it is quite limiting.
🔖 Changes
build.shso it prepends#!/usr/bin/env bashto the finalbashunitscript.✅ To-do list
CHANGELOG.mdto reflect the new feature or fix