Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 3.x #733

Closed
athasach opened this issue Mar 29, 2018 · 10 comments
Closed

Upgrade to TypeScript 3.x #733

athasach opened this issue Mar 29, 2018 · 10 comments

Comments

@athasach
Copy link

athasach commented Mar 29, 2018

When using new features of TypeScript 2.8 such as this one: https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#improved-control-over-mapped-type-modifiers

TypeDoc cannot process TypeScript files that use those features.

Update May 31, 2018: TypeScript 2.9 is out now.

Update July 30, 2018: TypeScript 3.0 is out now. https://blogs.msdn.microsoft.com/typescript/2018/07/30/announcing-typescript-3-0/

@bsunderhus
Copy link

Already tested manually to add the newest version of typescript in the typedoc itself and it worked just fine

$ typedoc ./src --out ./doc --module commonjs --target ES5 --hideGenerator --mode file --readme none --theme minimal --excludePrivate

Using TypeScript 2.8.1 from /home/myuser/Documents/mylib/node_modules/typedoc/node_modules/typescript/lib
Rendering [========================================] 100%

Documentation generated at /home/myuser/Documents/mylib/doc

Done in 4.60s.

@alisahinozcelik
Copy link

I have tried to use homomorphic mapped types but got this error:

interface IOptions {
  a?: string;
  b?: number;
}

type TNonOptionalOptions = {[P in keyof IOptions]-?: IOptions[P]};

Error: file.ts(6) ';' expected. Error: file.ts(6) Expression expected. Error: file.ts(6) Expression expected. Error: file.ts(6) Declaration or statement expected.

I have also tried Required<T> type from lib.d.ts but got this:

Cannot find name 'Required'

@aciccarello
Copy link
Collaborator

@alisahinozcelik did you get that error when running the current typedoc or the version in this PR?

@alisahinozcelik
Copy link

@aciccarello I have got the error at tsdoc@0.11.1 and typescript@2.8.3

@pranavjindal999
Copy link

common guys, please upgrade the TS version.

Following fails :(

type DeepPartial<T> = {
  [key in keyof T]?: T[key] extends Object ? DeepPartial<T[key]> : T[key]
};

@arogozine
Copy link

FYI TypeScript 2.9 is out soon

@athasach athasach changed the title Upgrade to TypeScript 2.8.x Upgrade to TypeScript 2.9.x May 31, 2018
@jasongrout
Copy link

See also #744.

@jasongrout
Copy link

Typescript 3.0 is out now.

Also, related issue: #822

@athasach athasach changed the title Upgrade to TypeScript 2.9.x Upgrade to TypeScript 3.x Aug 3, 2018
@ahocevar
Copy link
Contributor

ahocevar commented Aug 6, 2018

#824 provides the updates to make TypeDoc work with TypeScript 3.1.x.

@athasach
Copy link
Author

Addressed by #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants