-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.26 Beta
: Add json5
to defaults in option declaration for highlightLanguages
.
#2593
Comments
json5
to defaults in option declaration for highlightLanguages
.0.26 Beta
: Add json5
to defaults in option declaration for highlightLanguages
.
It's absurd to me that json5 gets that many downloads... that parser has awful non-linear performance! I consider TypeScript to be the canonical jsonc parser, with 51 million weekly downloads, but jsonc-parser used by VSCode has a nice 17 million as well. That said, it seems reasonable to load the json5 grammar by default, it's only an extra 3.87kb and one extra file, for something that's widely used. |
That makes more sense re |
Added in v0.26.0-beta.4 |
json5
was previously supported or enabled by default in TypeDoc0.25.x
.With the TypeDoc 0.26 beta the new
highlightLanguages
option default does not includejson5
. I'd say a good candidate to add to the default as it is widely used and makes it easy to add comments to example JSON blocks.I have tested that simply adding "json5" to the
highlightLanguages
provides default support.Info on JSON5. The NPM package has 70+MM weekly downloads, so is popular. This is compared to
jsonc
which is included in the default which has ~80k weekly downloadsThe text was updated successfully, but these errors were encountered: