Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for declaration output to include d.ts files for interfaces #175

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

rob-bateman
Copy link
Contributor

tackles the missing d.ts files for interface objects in typescript. closes #174

@rob-bateman
Copy link
Contributor Author

sorry for not updating tests but the current build appears to be failing anyway. I'm not a great test whiz so any help with this would be gratefully received!

@bartzy
Copy link

bartzy commented Apr 4, 2016

Any plans to merge this soon?

Thanks!

@jbrantly
Copy link
Member

jbrantly commented Apr 4, 2016

Yes, definitely, I've just been incredibly busy with other things recently and haven't had a lot of time to dedicate to this project. But this is a good change and will be merged and released.

@jbrantly jbrantly merged commit 6356367 into TypeStrong:master Apr 11, 2016
@jbrantly
Copy link
Member

Released in v0.8.2. Thanks!

@bartzy
Copy link

bartzy commented Apr 11, 2016

@jbrantly Thanks!

I noticed that on once upgrading to 0.8.2 (from 0.8.1), Now webpack outputs full paths to asset files. Is that on purpose? It makes seeing what changed in each compilation a bit more involved.

Thanks again.

@jbrantly
Copy link
Member

@bartzy just to be clear, are all files full paths or just declaration files?

That was not an intended change and I will see about fixing in the next release (which should be very soon). v0.8.2 was released somewhat hastily just to try to fix a long standing bug but there is more that I want to get released so v0.8.3 will be following shortly.

@bartzy
Copy link

bartzy commented Apr 11, 2016

@jbrantly Only declaration files are showing as full paths, sorry for the confusion.

@rob-bateman
Copy link
Contributor Author

@jbrantly sweet, thanks for merging!

@mrblackus
Copy link

Same issue as @bartzy here, all d.ts files are now generated with full absolute path inside build directory (the one set on webpack configuration).

@jbrantly Do you want me to open an issue for that? I didn't find one that references this error.

@jbrantly
Copy link
Member

@mrblackus That'd be great, thanks. Apologies for the regression.

@mrblackus
Copy link

No problem, issue is open here #186 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d.ts files for interfaces missing when declarations option enabled in tsconfig.json
4 participants