fix(webpack): remove deprecations introduced in webpack 5

[Delagen]

No description provided.

[johnnyreilly]

Thanks for the PR! Please could you provide some details covering what this is about / designed to achieve? It looks like this will make ts-loader only support webpack 5. Is that right?

[Delagen]

@johnnyreilly As i see in ci test, it completes, and fails in uncertain circumstances. So webpack 4 compatibility kept.
I only rewrote reduce to forEach, as Set object does not support it. And use getErrors method if exists instead of errors property.

[johnnyreilly]

it completes, and fails in uncertain circumstances

It seems to be failing consistently when comparison tests are run. A little background:

ts-loader has 2 test packs: execution tests (which run ts-loader and see if the result of invoking ts-loader results in passing tests) and comparison tests (which run ts-loader and test the output of ts-loader in comparison to known outputs which are part of the test pack).

Execution tests run as part of all test runs and are reliable. Comparison tests run only against the latest TypeScript version in the test pack (v3.6.3 in this instance; I need to update it) and are more brittle.

More can be read about the comparison test pack here: https://github.com/TypeStrong/ts-loader/blob/master/test/comparison-tests/README.md

It looks like the comparison tests are reliably failing. If you run yarn build && yarn comparison-tests what do you experience locally?

Also, it's still not clear to me what this PR is intended to do. Would you be able to provide a brief explanation please? It does seem like it may be breaking webpack 4 compatibility, is that intentional?

[Delagen]

Webpack typings does not updated yet, so ts-ignore comments used. It only remove warnings of deprecations on use in webpack 5 (Compilation.modules now is Set, so no reduce method, instead of Dependency.errors method getErrors offerred)

[johnnyreilly]

Webpack typings does not updated yet,

Send a PR to definitely typed to fix this. Mention me in the PR and I'll review it for you. Let's get that fixed rather than work around it.

[Delagen]

@johnnyreilly I think we need to wait to release, this changes does not prevent plugin to work)

[johnnyreilly]

I think we need to wait to release

For the webpack type definitions to be released? Once the PR is merged the release of them is automated. I can help there; I'm one of the maintainers of definitely typed.

Or did you mean webpack 5? I might be misunderstanding you

[Delagen]

I mean Webpack 5, as it will be out of beta пн, 30 дек. 2019 г., 11:54 John Reilly <notifications@github.com>:

…

I think we need to wait to release For the webpack type definitions to be released? Once the PR is merged the release of them is automated. I can help there; I'm one of the maintainers of definitely typed. Or did you mean webpack 5? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1047?email_source=notifications&email_token=AAF7HZYJ7YNQMCM7DLFV4STQ3GZODA5CNFSM4J734SFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZ25OY#issuecomment-569618107>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF7HZ656YEP2R6CKHEG5MLQ3GZODANCNFSM4J734SFA> .

[johnnyreilly]

It's possibly worth continuing with this. The fact that webpack 5 is in beta should mean the API is pretty stable. Either way, at least initially we'll be looking to support both webpack 4 and webpack 5 with ts-loader. But no worries if you'd rather wait 😄

[Delagen]

[DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET] DeprecationWarning: Compilation.modules was changed from Array to Set (using Array method 'reduce' is deprecated)
[DEP_WEBPACK_MODULE_ERRORS] DeprecationWarning: Module.errors was removed (use getErrors instead)

[Lisiadito]

I would love to see these warnings fixed

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing as stale. Please reopen if you'd like to work on this further.

[riarheos]

So how do we deal with this? Maybe reopen and apply the patch?

[riarheos]

Ah, looks like it was fixed between 8.0.0 and 8.0.3. Thanks!