Prepare for 2.3.5 release

.travis.yml

@@ -21,4 +21,3 @@ env:
   - TYPESCRIPT=typescript@2.0.9
   - TYPESCRIPT=typescript@1.8.2
   - TYPESCRIPT=typescript@1.7.5
-  - TYPESCRIPT=typescript@1.6.2

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## v2.3.5 - NOT RELEASED YET
+## v2.3.5
 
 - [Add an additional check for js files before reusing isExternalLibaryImport](https://github.com/TypeStrong/ts-loader/pull/622) (#620) - thanks @WillMartin
 - [Make TypeScript `basePath` configurable](https://github.com/TypeStrong/ts-loader/pull/621) (#618) - thanks @Loilo!

README.md

@@ -134,7 +134,7 @@ ts-loader supports the latest and greatest version of TypeScript right back to v
 
 ts-loader supports webpack 2.  It may well still work with webpack 1 but it does not officially support webpack 1 any longer.  Our continuous integration test suites run against webpack 2; **not** webpack 1. 
 
-A full test suite runs each night (and on each pull request). It runs both on [Linux](https://travis-ci.org/TypeStrong/ts-loader) and [Windows](https://ci.appveyor.com/project/JohnReilly/ts-loader), testing ts-loader against each major release of TypeScript from the latest right back to 1.6.  The test suite also runs against TypeScript@next (because we want to use it as much as you do).
+A full test suite runs each night (and on each pull request). It runs both on [Linux](https://travis-ci.org/TypeStrong/ts-loader) and [Windows](https://ci.appveyor.com/project/JohnReilly/ts-loader), testing ts-loader against major releases of TypeScript.  The test suite also runs against TypeScript@next (because we want to use it as much as you do).
 
 If you become aware of issues not caught by the test suite then please let us know. Better yet, write a test and submit it in a PR!
 

appveyor.yml

@@ -11,7 +11,6 @@ environment:
   - TYPESCRIPT: typescript@2.0.9
   - TYPESCRIPT: typescript@1.8.2
   - TYPESCRIPT: typescript@1.7.5
-  - TYPESCRIPT: typescript@1.6.2
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-loader",
-  "version": "2.3.4",
+  "version": "2.3.5",
   "description": "TypeScript loader for webpack",
   "main": "index.js",
   "scripts": {

src/interfaces.ts

@@ -284,7 +284,7 @@ export interface ResolvedModule {
 
 export interface TSCompatibleCompiler {
     // typescript@next 1.7+
-    readConfigFile(fileName: string, readFile: (path: string) => string): {
+    readConfigFile(fileName: string, readFile: (path: string, encoding?: string | undefined) => string | undefined): {
         config?: any;
         error?: typescript.Diagnostic;
     };

src/utils.ts

@@ -114,8 +114,9 @@ export function collectAllDependants(
     const result = {};
     result[fileName] = true;
     collected[fileName] = true;
-    if (reverseDependencyGraph[fileName]) {
-        Object.keys(reverseDependencyGraph[fileName]).forEach(dependantFileName => {
+    const dependants = reverseDependencyGraph[fileName];
+    if (dependants !== undefined) {
+        Object.keys(dependants).forEach(dependantFileName => {
             if (!collected[dependantFileName]) {
                 collectAllDependants(reverseDependencyGraph, dependantFileName, collected)
                     .forEach(fName => result[fName] = true);

test/comparison-tests/aliasResolution/expectedOutput-2.5/bundle.js

@@ -0,0 +1,90 @@
+/******/ (function(modules) { // webpackBootstrap
+/******/ 	// The module cache
+/******/ 	var installedModules = {};
+/******/
+/******/ 	// The require function
+/******/ 	function __webpack_require__(moduleId) {
+/******/
+/******/ 		// Check if module is in cache
+/******/ 		if(installedModules[moduleId]) {
+/******/ 			return installedModules[moduleId].exports;
+/******/ 		}
+/******/ 		// Create a new module (and put it into the cache)
+/******/ 		var module = installedModules[moduleId] = {
+/******/ 			i: moduleId,
+/******/ 			l: false,
+/******/ 			exports: {}
+/******/ 		};
+/******/
+/******/ 		// Execute the module function
+/******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
+/******/
+/******/ 		// Flag the module as loaded
+/******/ 		module.l = true;
+/******/
+/******/ 		// Return the exports of the module
+/******/ 		return module.exports;
+/******/ 	}
+/******/
+/******/
+/******/ 	// expose the modules object (__webpack_modules__)
+/******/ 	__webpack_require__.m = modules;
+/******/
+/******/ 	// expose the module cache
+/******/ 	__webpack_require__.c = installedModules;
+/******/
+/******/ 	// identity function for calling harmony imports with the correct context
+/******/ 	__webpack_require__.i = function(value) { return value; };
+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {
+/******/ 			Object.defineProperty(exports, name, {
+/******/ 				configurable: false,
+/******/ 				enumerable: true,
+/******/ 				get: getter
+/******/ 			});
+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {
+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);
+/******/ 		return getter;
+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
+/******/
+/******/ 	// __webpack_public_path__
+/******/ 	__webpack_require__.p = "";
+/******/
+/******/ 	// Load entry module and return exports
+/******/ 	return __webpack_require__(__webpack_require__.s = 1);
+/******/ })
+/************************************************************************/
+/******/ ([
+/* 0 */
+/***/ (function(module, exports, __webpack_require__) {
+
+"use strict";
+
+module.exports = 'myComponent';
+
+
+/***/ }),
+/* 1 */
+/***/ (function(module, exports, __webpack_require__) {
+
+"use strict";
+
+exports.__esModule = true;
+var myComponent = __webpack_require__(0);
+console.log(myComponent);
+
+
+/***/ })
+/******/ ]);

test/comparison-tests/aliasResolution/expectedOutput-2.5/output.transpiled.txt

@@ -0,0 +1,5 @@
+    Asset     Size  Chunks             Chunk Names
+bundle.js  2.89 kB       0  [emitted]  main
+chunk    {0} bundle.js (main) 166 bytes [entry] [rendered]
+    [0] ./.test/aliasResolution/common/components/myComponent.ts 46 bytes {0} [built]
+    [1] ./.test/aliasResolution/app.ts 120 bytes {0} [built]

test/comparison-tests/aliasResolution/expectedOutput-2.5/output.txt

@@ -0,0 +1,8 @@
+    Asset     Size  Chunks             Chunk Names
+bundle.js  2.89 kB       0  [emitted]  main
+chunk    {0} bundle.js (main) 166 bytes [entry] [rendered]
+    [0] ./.test/aliasResolution/common/components/myComponent.ts 46 bytes {0} [built]
+    [1] ./.test/aliasResolution/app.ts 120 bytes {0} [built] [1 error]
+
+ERROR in ./.test/aliasResolution/app.ts
+(2,31): error TS2307: Cannot find module 'components/myComponent2'.